flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-5528) tests: reduce the retry delay in QueryableStateITCase
Date Tue, 17 Jan 2017 15:08:26 GMT

    [ https://issues.apache.org/jira/browse/FLINK-5528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15826185#comment-15826185
] 

ASF GitHub Bot commented on FLINK-5528:
---------------------------------------

GitHub user NicoK opened a pull request:

    https://github.com/apache/flink/pull/3139

    [FLINK-5528][query][tests] reduce the retry delay in QueryableStateITCase

    Using 100ms instead of the 1s previously used does not impose too much
    additional query load and reduces the test suite's duration from 16-20s to
    13-15s on my machine with the current set of unit tests. Further reductions
    in the retry delay do not yield more improvements so far.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/NicoK/flink flink-5528

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3139.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3139
    
----
commit d9070946d6f56e2b48d69b61608b10b063b456b4
Author: Nico Kruber <nico@data-artisans.com>
Date:   2017-01-17T14:01:32Z

    [FLINK-5528][query][tests] reduce the retry delay in QueryableStateITCase
    
    Using 100ms instead of the 1s previously used does not impose too much
    additional query load and reduces the test suite's duration from 16-20s to
    13-15s on my machine with the current set of unit tests. Further reductions
    in the retry delay do not yield more improvements so far.

----


> tests: reduce the retry delay in QueryableStateITCase
> -----------------------------------------------------
>
>                 Key: FLINK-5528
>                 URL: https://issues.apache.org/jira/browse/FLINK-5528
>             Project: Flink
>          Issue Type: Improvement
>          Components: Queryable State
>    Affects Versions: 1.2.0
>            Reporter: Nico Kruber
>            Assignee: Nico Kruber
>
> The QueryableStateITCase uses a retry of 1 second, e.g. if a queried key does not exist
yet. This seems a bit too conservative as the job may not take that long to deploy and especially
since getKvStateWithRetries() recovers from failures by retrying.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message