flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-5528) tests: reduce the retry delay in QueryableStateITCase
Date Fri, 20 Jan 2017 15:22:26 GMT

    [ https://issues.apache.org/jira/browse/FLINK-5528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15831930#comment-15831930
] 

ASF GitHub Bot commented on FLINK-5528:
---------------------------------------

Github user uce commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3139#discussion_r97091734
  
    --- Diff: flink-tests/src/test/java/org/apache/flink/test/query/QueryableStateITCase.java
---
    @@ -1073,6 +1056,20 @@ public Integer getKey(Tuple2<Integer, Long> value) throws
Exception {
     		}
     	}
     
    +	/**
    +	 * Runs {@link #getKvStateWithRetries(QueryableStateClient, JobID, String,
    +	 * int, byte[], FiniteDuration)} with a fixed retry delay of 100ms.
    +	 */
    +	private static Future<byte[]> getKvStateWithRetries(
    +		final QueryableStateClient client,
    +		final JobID jobId,
    +		final String queryName,
    +		final int key,
    +		final byte[] serializedKey) {
    +		return getKvStateWithRetries(client, jobId, queryName, key, serializedKey,
    +			new FiniteDuration(100, TimeUnit.MILLISECONDS));
    --- End diff --
    
    I will make this a static final field of the class


> tests: reduce the retry delay in QueryableStateITCase
> -----------------------------------------------------
>
>                 Key: FLINK-5528
>                 URL: https://issues.apache.org/jira/browse/FLINK-5528
>             Project: Flink
>          Issue Type: Improvement
>          Components: Queryable State
>    Affects Versions: 1.2.0
>            Reporter: Nico Kruber
>            Assignee: Nico Kruber
>
> The QueryableStateITCase uses a retry of 1 second, e.g. if a queried key does not exist
yet. This seems a bit too conservative as the job may not take that long to deploy and especially
since getKvStateWithRetries() recovers from failures by retrying.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message