flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-5608) Cancel button not always visible
Date Fri, 27 Jan 2017 17:09:24 GMT

    [ https://issues.apache.org/jira/browse/FLINK-5608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15843133#comment-15843133
] 

ASF GitHub Bot commented on FLINK-5608:
---------------------------------------

Github user rehevkor5 commented on the issue:

    https://github.com/apache/flink/pull/3189
  
    @zentol I updated the commit: the overall job status count is now displayed in medium-width
(but not small or below), and I move the job status count to the right of job start/end &
duration.
    
    Also, I applied the float-right fix to the "Stop" button, which I didn't notice before.
    
    You can see that the fix isn't perfect when the job name is long, but it's still better
than what it was. Screenshots from Chrome 55.0.2883.95, controlling window width in the dev
tool.
    
    1200px:
    ![1200-2](https://cloud.githubusercontent.com/assets/16899/22379830/a6b3a062-e480-11e6-8d6a-d4a40a235597.png)
    
    1128px (you can see the top navbar wrapping down & peeking out from behind the secondary
navbar:
    ![1128-2](https://cloud.githubusercontent.com/assets/16899/22379837/ae8959bc-e480-11e6-8de8-2d9b05af1ee9.png)
    
    1020px (back to normal because left navbar is collapsed):
    ![1020-2](https://cloud.githubusercontent.com/assets/16899/22379866/c571038c-e480-11e6-8ab0-ce6e5eec489a.png)
    
    992px (wrapping again):
    ![992-2](https://cloud.githubusercontent.com/assets/16899/22379876/d2967ae2-e480-11e6-9104-ab884e04ebfa.png)
    
    991px:
    ![991-2](https://cloud.githubusercontent.com/assets/16899/22379898/e915e9c4-e480-11e6-8a42-8f3fb73b43d4.png)



> Cancel button not always visible
> --------------------------------
>
>                 Key: FLINK-5608
>                 URL: https://issues.apache.org/jira/browse/FLINK-5608
>             Project: Flink
>          Issue Type: Bug
>          Components: Webfrontend
>    Affects Versions: 1.1.4
>            Reporter: Shannon Carey
>            Assignee: Shannon Carey
>            Priority: Minor
>
> When the window is not wide enough, or when the job name is too long, the "Cancel" button
in the Job view of the web UI is not visible because it is the first element that gets wrapped
down and gets covered by the secondary navbar (the tabs). This causes us to often need to
resize the browser wider than our monitor in order to use the cancel button.
> In general, the use of Bootstrap's ".navbar-fixed-top" is problematic if the content
may wrap, especially if the content's horizontal width if not known & fixed. The ".navbar-fixed-top"
uses fixed positioning, and therefore any unexpected change in height will result in overlap
with the rest of the normal-flow content in the page. The Bootstrap docs explain this in their
"Overflowing content" callout.
> I am submitting a PR which does not attempt to resolve all issues with the fixed navbar
approach, but attempts to improve the situation by using less horizontal space and by altering
the layout approach of the Cancel button.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message