flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-5608) Cancel button not always visible
Date Sun, 22 Jan 2017 20:55:27 GMT

    [ https://issues.apache.org/jira/browse/FLINK-5608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833696#comment-15833696
] 

ASF GitHub Bot commented on FLINK-5608:
---------------------------------------

GitHub user rehevkor5 opened a pull request:

    https://github.com/apache/flink/pull/3189

    [FLINK-5608] [webfrontend] Cancel button stays visible in narrow windows

    - Most importantly, the Cancel button has been changed to float
    right, and will only wrap downward if pushed out by the job name
    - Also combined the job name and job id into a single horizontal
    element, reducing the overall horizontal space taken by the main
    navbar components in the job view, making the main navbar components
    less likely to wrap downward and be overlapped by the secondary navbar.
    - Compiled code has been rebuilt
    
    Thanks for contributing to Apache Flink. Before you open your pull request, please take
the following check list into consideration.
    If your changes take all of the items into account, feel free to open your pull request.
For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful description of your
changes.
    
    - [ ] General
      - The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the JIRA id)
    
    - [ ] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [ ] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rehevkor5/flink ui_job_cancel_button_layout_issue

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3189.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3189
    
----
commit 33e3a14ebd3d614a6e5d4eae90f5985416e0b995
Author: Shannon Carey <rehevkor5@gmail.com>
Date:   2017-01-22T20:52:43Z

    [FLINK-5608] [webfrontend] Cancel button stays visible in narrow windows
    
    - Most importantly, the Cancel button has been changed to float
    right, and will only wrap downward if pushed out by the job name
    - Also combined the job name and job id into a single horizontal
    element, reducing the overall horizontal space taken by the main
    navbar components in the job view, making the main navbar components
    less likely to wrap downward and be overlapped by the secondary navbar.
    - Compiled code has been rebuilt

----


> Cancel button not always visible
> --------------------------------
>
>                 Key: FLINK-5608
>                 URL: https://issues.apache.org/jira/browse/FLINK-5608
>             Project: Flink
>          Issue Type: Bug
>          Components: Webfrontend
>    Affects Versions: 1.1.4
>            Reporter: Shannon Carey
>            Assignee: Shannon Carey
>            Priority: Minor
>
> When the window is not wide enough, or when the job name is too long, the "Cancel" button
in the Job view of the web UI is not visible because it is the first element that gets wrapped
down and gets covered by the secondary navbar (the tabs). This causes us to often need to
resize the browser wider than our monitor in order to use the cancel button.
> In general, the use of Bootstrap's ".navbar-fixed-top" is problematic if the content
may wrap, especially if the content's horizontal width if not known & fixed. The ".navbar-fixed-top"
uses fixed positioning, and therefore any unexpected change in height will result in overlap
with the rest of the normal-flow content in the page. The Bootstrap docs explain this in their
"Overflowing content" callout.
> I am submitting a PR which does not attempt to resolve all issues with the fixed navbar
approach, but attempts to improve the situation by using less horizontal space and by altering
the layout approach of the Cancel button.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message