flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zentol <...@git.apache.org>
Subject [GitHub] flink pull request #3109: [FLINK-5329] Fix metric list being cut off
Date Thu, 12 Jan 2017 18:07:06 GMT
GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/3109

    [FLINK-5329] Fix metric list being cut off

    This PR fixes the metric list in the WebFrontend job page being cut off. This bug was
introduced in bd62fe14ac3e8c382b72c7c16ce1f0a6ee7db77d.
    
    To fix it the menu is now simply opening downwards instead of upwards.
    
    In addition,
    * metric identifiers are aligned to the right, since the metric name is at the end of
the identifier, which is the primary search criteria in most cases. It also just looks better
imo :)
    * metric names are now truncated if they exceed 73 characters, in that case the first
and last 35 characters are displayed, divided by ```...```.
    
    Preview:
    ![result](https://cloud.githubusercontent.com/assets/5725237/21901720/229cb68e-d8f9-11e6-8674-e94704b55124.png)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 5329_metric_list

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3109.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3109
    
----
commit 44f68b55227ee7c3af4d2c0634e3bd6b11a28873
Author: zentol <chesnay@apache.org>
Date:   2017-01-12T17:52:56Z

    [FLINK-5329] Fix metric list being cut off

commit eb62f1c99db26e718cecef473fba02c838afe778
Author: zentol <chesnay@apache.org>
Date:   2017-01-12T17:56:21Z

    Generated content

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message