flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rehevkor5 <...@git.apache.org>
Subject [GitHub] flink pull request #3189: [FLINK-5608] [webfrontend] Cancel button stays vis...
Date Sun, 22 Jan 2017 20:55:24 GMT
GitHub user rehevkor5 opened a pull request:

    https://github.com/apache/flink/pull/3189

    [FLINK-5608] [webfrontend] Cancel button stays visible in narrow windows

    - Most importantly, the Cancel button has been changed to float
    right, and will only wrap downward if pushed out by the job name
    - Also combined the job name and job id into a single horizontal
    element, reducing the overall horizontal space taken by the main
    navbar components in the job view, making the main navbar components
    less likely to wrap downward and be overlapped by the secondary navbar.
    - Compiled code has been rebuilt
    
    Thanks for contributing to Apache Flink. Before you open your pull request, please take
the following check list into consideration.
    If your changes take all of the items into account, feel free to open your pull request.
For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful description of your
changes.
    
    - [ ] General
      - The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the JIRA id)
    
    - [ ] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [ ] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rehevkor5/flink ui_job_cancel_button_layout_issue

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3189.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3189
    
----
commit 33e3a14ebd3d614a6e5d4eae90f5985416e0b995
Author: Shannon Carey <rehevkor5@gmail.com>
Date:   2017-01-22T20:52:43Z

    [FLINK-5608] [webfrontend] Cancel button stays visible in narrow windows
    
    - Most importantly, the Cancel button has been changed to float
    right, and will only wrap downward if pushed out by the job name
    - Also combined the job name and job id into a single horizontal
    element, reducing the overall horizontal space taken by the main
    navbar components in the job view, making the main navbar components
    less likely to wrap downward and be overlapped by the secondary navbar.
    - Compiled code has been rebuilt

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message