flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ramkrish86 <...@git.apache.org>
Subject [GitHub] flink issue #3149: FLINK-2168 Add HBaseTableSource
Date Wed, 01 Feb 2017 07:22:11 GMT
Github user ramkrish86 commented on the issue:

    https://github.com/apache/flink/pull/3149
  
    > Regarding the HBaseTableSchema, we could also use it only internally and not expose
it to the user. The HBaseTableSource would have a method addColumn() and forward the calls
to its internal HBaseSchema.
    
    Have done this. I initially thought to do things in the construction time itself. Now
added an addColumn() in hbaseTableSource. HBaseSchema becomes totally package private and
no access to users.
    
    Regarding the flatSchema, generally in hbase only family is required and the qualifiers
are just dynamic. But here for the sake of accessibility we expect the user to specify the
column names. (trying to give a relational look). It is in case of projections is where we
have some issues. In my opinion if we have a better API for Projection may be we could handle
it better? The current nested way as you said is better in the sense that all columns of a
family are grouped together. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message