flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #3252: [FLINK-5624] Support tumbling window on streaming ...
Date Mon, 13 Feb 2017 17:27:05 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3252#discussion_r100837291
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/calls/FunctionGenerator.scala
---
    @@ -290,6 +291,15 @@ object FunctionGenerator {
         Seq(),
         new CurrentTimePointCallGen(SqlTimeTypeInfo.TIMESTAMP, local = true))
     
    +  // Make ROWTIME() return the local timestamp
    +  // The function has to be executable as in windowed queries it is used
    +  // in the GroupBy expression. The results of the function, however, does
    +  // not matter.
    +  addSqlFunction(
    +    EventTimeExtractor,
    +    Seq(),
    +    new CurrentTimePointCallGen(SqlTimeTypeInfo.TIMESTAMP, local = true))
    --- End diff --
    
    This function should not be called. So, I would suggest to create a `CallGenerator` that
throws an exception, if possible when the code is generated, alternatively in the generated
code. PR #3271 will need the same call generator.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message