flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tzulitai <...@git.apache.org>
Subject [GitHub] flink pull request #3314: [FLINK-3679] DeserializationSchema should handle z...
Date Fri, 24 Feb 2017 09:07:12 GMT
Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3314#discussion_r102902685
  
    --- Diff: flink-connectors/flink-connector-kafka-0.10/src/test/java/org/apache/flink/streaming/connectors/kafka/Kafka010FetcherTest.java
---
    @@ -119,7 +119,7 @@ public Void answer(InvocationOnMock invocation) {
             @SuppressWarnings("unchecked")
             SourceContext<String> sourceContext = mock(SourceContext.class);
             List<KafkaTopicPartition> topics = Collections.singletonList(new KafkaTopicPartition("test",
42));
    -        KeyedDeserializationSchema<String> schema = new KeyedDeserializationSchemaWrapper<>(new
SimpleStringSchema());
    +        RichKeyedDeserializationSchemaWrapper<String> schema = new RichKeyedDeserializationSchemaWrapper<>(new
SimpleStringSchema());
    --- End diff --
    
    This file will have conflict with the current `master`, because I recently pushed a hotfix
to `master` to fix the indentation of this file (previously, it's incorrectly using spaces
to indent instead of tabs). Sorry about this!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message