flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-2168) Add HBaseTableSource
Date Wed, 01 Feb 2017 00:45:52 GMT

    [ https://issues.apache.org/jira/browse/FLINK-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15847807#comment-15847807
] 

ASF GitHub Bot commented on FLINK-2168:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3149#discussion_r98805674
  
    --- Diff: flink-connectors/flink-hbase/src/main/java/org/apache/flink/addons/hbase/TableInputFormat.java
---
    @@ -41,7 +41,7 @@
     /**
      * {@link InputFormat} subclass that wraps the access for HTables.
      */
    -public abstract class TableInputFormat<T extends Tuple> extends RichInputFormat<T,
TableInputSplit> {
    +public abstract class TableInputFormat<T> extends RichInputFormat<T, TableInputSplit>
{
    --- End diff --
    
    I'd rather rename this class to `AbstractTableInputFormat<T>` and add a new class
`TableInputFormat<T extends Tuple>` to keep the API stable.


> Add HBaseTableSource
> --------------------
>
>                 Key: FLINK-2168
>                 URL: https://issues.apache.org/jira/browse/FLINK-2168
>             Project: Flink
>          Issue Type: New Feature
>          Components: Table API & SQL
>    Affects Versions: 0.9
>            Reporter: Fabian Hueske
>            Assignee: ramkrishna.s.vasudevan
>            Priority: Minor
>              Labels: starter
>
> Add a {{HBaseTableSource}} to read data from a HBase table. The {{HBaseTableSource}}
should implement the {{ProjectableTableSource}} (FLINK-3848) and {{FilterableTableSource}}
(FLINK-3849) interfaces.
> The implementation can be based on Flink's {{TableInputFormat}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message