flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-5606) Remove magic number in key and namespace serialization
Date Thu, 02 Feb 2017 10:34:54 GMT

    [ https://issues.apache.org/jira/browse/FLINK-5606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15849771#comment-15849771
] 

ASF GitHub Bot commented on FLINK-5606:
---------------------------------------

GitHub user dawidwys opened a pull request:

    https://github.com/apache/flink/pull/3253

    [FLINK-5606] Remove magic number in key and namespace serialization

    Thanks for contributing to Apache Flink. Before you open your pull request, please take
the following check list into consideration.
    If your changes take all of the items into account, feel free to open your pull request.
For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful description of your
changes.
    
    - [x] General
      - The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the JIRA id)
    
    - [x] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [x] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dawidwys/flink magicNumber

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3253.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3253
    
----
commit 19b9c9c03f10bbeaef7ab7ed008b263842c18d40
Author: Dawid Wysakowicz <dawid@getindata.com>
Date:   2017-02-02T10:30:03Z

    [FLINK-5606] Remove magic number in key and namespace serialization

----


> Remove magic number in key and namespace serialization
> ------------------------------------------------------
>
>                 Key: FLINK-5606
>                 URL: https://issues.apache.org/jira/browse/FLINK-5606
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Queryable State
>            Reporter: Ufuk Celebi
>            Priority: Minor
>
> The serialized key and namespace for state queries contains a magic number between the
key and namespace: {{key|42|namespace}}. This was for historical reasons in order to skip
deserialization of the key and namespace for our old {{RocksDBStateBackend}} which used the
same format. This has now been superseded by the keygroup aware state backends and there is
no point in doing this.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message