flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-5624) Support tumbling window on streaming tables in the SQL API
Date Mon, 13 Feb 2017 22:36:41 GMT

    [ https://issues.apache.org/jira/browse/FLINK-5624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15864603#comment-15864603

ASF GitHub Bot commented on FLINK-5624:

Github user haohui commented on a diff in the pull request:

    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/calls/FunctionGenerator.scala
    @@ -290,6 +291,15 @@ object FunctionGenerator {
         new CurrentTimePointCallGen(SqlTimeTypeInfo.TIMESTAMP, local = true))
    +  // Make ROWTIME() return the local timestamp
    +  // The function has to be executable as in windowed queries it is used
    +  // in the GroupBy expression. The results of the function, however, does
    +  // not matter.
    +  addSqlFunction(
    +    EventTimeExtractor,
    +    Seq(),
    +    new CurrentTimePointCallGen(SqlTimeTypeInfo.TIMESTAMP, local = true))
    --- End diff --
    It turns out that the function is used all the way in runtime -- the translated plan looks
like the following:
    LogicalAggregate(group={0}, ...)
      LogicalProject($0=FLOOR(ROWTIME() TO HOURS)))
    The expression is used in the projection. Unfortunately there is no trivial way to exclude
it in Calcite as mentioned in the last comments.
    The results of expression is not used in the query though.

> Support tumbling window on streaming tables in the SQL API
> ----------------------------------------------------------
>                 Key: FLINK-5624
>                 URL: https://issues.apache.org/jira/browse/FLINK-5624
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>            Reporter: Haohui Mai
>            Assignee: Haohui Mai
> This is a follow up of FLINK-4691.
> FLINK-4691 adds supports for group-windows for streaming tables. This jira proposes to
expose the functionality in the SQL layer via the {{GROUP BY}} clauses, as described in http://calcite.apache.org/docs/stream.html#tumbling-windows.

This message was sent by Atlassian JIRA

View raw message