flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From uce <...@git.apache.org>
Subject [GitHub] flink pull request #3440: [backport-1.2] [FLINK-5934] Set the Scheduler in t...
Date Wed, 01 Mar 2017 15:23:50 GMT
Github user uce commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3440#discussion_r103708910
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java
---
    @@ -184,31 +202,14 @@
     
     	// ------ Fields that are relevant to the execution and need to be cleared before archiving
 -------
     
    -	/** The slot provider to use for allocating slots for tasks as they are needed */
    -	private SlotProvider slotProvider;
    -
    -	/** Strategy to use for restarts */
    -	private RestartStrategy restartStrategy;
    -
    -	/** The classloader for the user code. Needed for calls into user code classes */
    -	private ClassLoader userClassLoader;
    -
     	/** The coordinator for checkpoints, if snapshot checkpoints are enabled */
     	private CheckpointCoordinator checkpointCoordinator;
     
     	/** Checkpoint stats tracker separate from the coordinator in order to be
     	 * available after archiving. */
    +	@SuppressWarnings("NonSerializableFieldInSerializableClass")
     	private CheckpointStatsTracker checkpointStatsTracker;
    --- End diff --
    
    Shouldn't these be `transient` instead?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message