flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rmetzger <...@git.apache.org>
Subject [GitHub] flink issue #3438: [FLINK-4460] Allow ProcessFunction on non-keyed streams
Date Fri, 03 Mar 2017 20:47:11 GMT
Github user rmetzger commented on the issue:

    https://github.com/apache/flink/pull/3438
  
    I looked over the changes and didn't find anything critical. The only thing that made
me thinking was the boxed `Long` type for the timestamp(). I assume you decided for this approach
to signal timestamp unavailability using `null`. The Java documentation does not recommend
to rely on autoboxing for performance critical code: http://docs.oracle.com/javase/1.5.0/docs/guide/language/autoboxing.html
    
    Tests, Scala API were done. I assume that we don't need to explicitly mention support
for the process function on non-keyed streams.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message