flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #3364: [FLINK-5047] [table] Add sliding group-windows for...
Date Mon, 06 Mar 2017 21:40:42 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3364#discussion_r104525345
  
    --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/batch/table/GroupWindowTest.scala
---
    @@ -360,6 +360,19 @@ class GroupWindowTest extends TableTestBase {
           .window(Session withGap 7.milli as 'w) // require on a time attribute
           .groupBy('string, 'w)
           .select('string, 'int.count)
    +
    +    val expected = unaryNode(
    --- End diff --
    
    Why do you add the expected result to a test which is expected to fail?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message