flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zhijiangW <...@git.apache.org>
Subject [GitHub] flink issue #3455: [FLINK-5134] [runtime] [FLIP-6] Aggregate ResourceSpec fo...
Date Wed, 08 Mar 2017 08:51:48 GMT
Github user zhijiangW commented on the issue:

    https://github.com/apache/flink/pull/3455
  
    @StephanEwen , thank you for reviews and suggestions.
    
    I would add the related tests for `JobGraphGenerator` and try to cover different chained
modes.
    
    BTW, I will also remove the previous comments for `setResources` public methods and change
to private methods. So the tests can call them via reflection as mentioned in slack. What
do you think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message