flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dawidwys <...@git.apache.org>
Subject [GitHub] flink pull request #3477: [Flink-3318][cep] Add support for quantifiers to C...
Date Tue, 14 Mar 2017 09:34:48 GMT
Github user dawidwys commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3477#discussion_r105854116
  
    --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java ---
    @@ -209,33 +204,66 @@ public boolean equals(Object obj) {
     			return nonDuplicatingTypeSerializer.equals(other.nonDuplicatingTypeSerializer) &&
     				sharedBuffer.equals(other.sharedBuffer) &&
     				states.equals(other.states) &&
    -				windowTime == other.windowTime &&
    -				startEventCounter == other.startEventCounter;
    +				windowTime == other.windowTime;
     		} else {
     			return false;
     		}
     	}
     
     	@Override
     	public int hashCode() {
    -		return Objects.hash(nonDuplicatingTypeSerializer, sharedBuffer, states, windowTime,
startEventCounter);
    +		return Objects.hash(nonDuplicatingTypeSerializer, sharedBuffer, states, windowTime);
    +	}
    +
    --- End diff --
    
    It is needed to tell if `IGNORE` is self ignore meaning we stay e.g. in a looping state.
Looping state can consist of two states with one not containing `PROCEED` edges. 
    
    So this method is required just in the `IGNORE` context, so I think it does not fit into
the `State` class.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message