flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rmetzger <...@git.apache.org>
Subject [GitHub] flink pull request #3549: [backport-1.1] [FLINK-5701] [kafka] FlinkKafkaProd...
Date Wed, 15 Mar 2017 16:53:42 GMT
Github user rmetzger commented on a diff in the pull request:

    --- Diff: flink-streaming-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducerBase.java
    @@ -374,4 +380,11 @@ public static Properties getPropertiesFromBrokerList(String brokerList)
     		props.setProperty(ProducerConfig.BOOTSTRAP_SERVERS_CONFIG, brokerList);
     		return props;
    +	// this is exposed for testing purposes
    +	protected long numPendingRecords() {
    --- End diff --
    There is the `@VisibleForTesting` annotation for that :)

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message