flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zhijiangW <...@git.apache.org>
Subject [GitHub] flink issue #3555: [FLINK-6076] Refactor HeartbeatManager to extend Heartbea...
Date Thu, 16 Mar 2017 14:32:31 GMT
Github user zhijiangW commented on the issue:

    https://github.com/apache/flink/pull/3555
  
    @tillrohrmann , it is really good to pass the `HeartbeatListener` directly when construct
the `HeartbeatManagerImpl`. When I realized the heartbeat logic between different components
like TM and JM, it is a little difficult to control the process between threads in order to
verify the timeout expectation in tests. Now the `HeartbeatListener` is exposed out of the
world, the test can extend the `notifyHeartbeatTimeout` method to control the process more
easily.
    
    And I also notice that you change the `sendHeartbeat` to `receiveHeartbeat`, have you
considered to use `responseHeartbeat` instead which is constract with `requestHeartbeat`.
    
    BTW, what is your suggestions of my current pull requests related with this modification?
Should I resubmit that after this improvement merging into master?  Thank you!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message