flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rtudoran <...@git.apache.org>
Subject [GitHub] flink pull request #3547: [FLINK-5653] Add processing time OVER ROWS BETWEEN...
Date Fri, 17 Mar 2017 09:49:25 GMT
Github user rtudoran commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3547#discussion_r106615434
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/BoundedProcessingOverAllWindowFunction.scala
---
    @@ -0,0 +1,97 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.flink.table.runtime.aggregate
    +
    +import org.apache.flink.api.java.tuple.Tuple
    +import org.apache.flink.types.Row
    +import org.apache.flink.configuration.Configuration
    +import org.apache.flink.streaming.api.functions.windowing.RichWindowFunction
    +import org.apache.flink.streaming.api.windowing.windows.Window
    +import org.apache.flink.util.Collector
    +import org.apache.flink.table.functions.AggregateFunction
    +import org.apache.flink.api.java.typeutils.RowTypeInfo
    +import org.apache.flink.util.Preconditions
    +import org.apache.flink.table.functions.Accumulator
    +import java.lang.Iterable
    +import org.apache.flink.streaming.api.functions.windowing.RichAllWindowFunction
    +
    +class BoundedProcessingOverAllWindowFunction[W <: Window](
    +  private val aggregates: Array[AggregateFunction[_]],
    +  private val aggFields: Array[Int],
    +  private val forwardedFieldCount: Int)
    +    extends RichAllWindowFunction[Row, Row, W] {
    +
    +  Preconditions.checkNotNull(aggregates)
    +  Preconditions.checkNotNull(aggFields)
    +  Preconditions.checkArgument(aggregates.length == aggFields.length)
    +
    +  private var output: Row = _
    +  private var accumulators: Row = _
    +  private var reuse: Row = _
    +
    +  output = new Row(forwardedFieldCount + aggregates.length)
    +  if (null == accumulators) {
    +    accumulators = new Row(aggregates.length)
    +  }
    +
    +  override def apply(
    +    window: W,
    +    records: Iterable[Row],
    +    out: Collector[Row]): Unit = {
    +
    +    var i = 0
    +    // setting the accumulators for each aggregation
    +    while (i < aggregates.length) {
    +      accumulators.setField(i, aggregates(i).createAccumulator())
    --- End diff --
    
    What is the meaning of the acc?
    What should be passed to the accumulator for reset? logically I would expect that this
is a non parameterized method


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message