flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rtudoran <...@git.apache.org>
Subject [GitHub] flink pull request #3550: [FLINK-5654] - Add processing time OVER RANGE BETW...
Date Fri, 17 Mar 2017 16:16:58 GMT
Github user rtudoran commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3550#discussion_r106688280
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
    @@ -785,7 +785,7 @@ object AggregateUtil {
         (propPos._1, propPos._2)
       }
     
    -  private def transformToAggregateFunctions(
    --- End diff --
    
    It is not to much logic...and the overall "createTimeBoundedProcessingTimeOverWindow"
is not bigger than the other method for unbound.
    ...as I said...it is the same...so as you prefer


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message