flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] flink issue #3633: [FLINK-5982] [runtime] Refactor AbstractInvokable and Sta...
Date Tue, 28 Mar 2017 17:22:15 GMT
Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/3633
  
    Thanks for this refactoring. I had only a quick look so far, but one thought was that
this patch could probably be simplified by making `triggerCheckpoint()` (and restore / notifyComplete)
not abstract in the `AbstractInvokable`. Instead let it throw the `UnsupportedOperationException`.
    
    That way, we avoid refactoring all the test classes to implement those methods (which
would be nice).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message