flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Patrick Lucas (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3026) Publish the flink docker container to the docker registry
Date Tue, 14 Mar 2017 10:40:41 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15923956#comment-15923956

Patrick Lucas commented on FLINK-3026:

Personally I like the idea of having as little code as possible in the docker-entrypoint.sh
script. I think it should be designed to basically work in all Flink versions going forward.
I suppose that would mean that we should have some scripts on the PATH named 'jobmanager'
and 'taskmanager' so that docker-entrypoint.sh can effectively just be:

#!/bin/bash -e

# Drop root privs code here

exec "$@"

And absolutely these builds will be automated—see my note in README.md about generating
the .travis.yml config. I just built some images as a proof of concept and to think about
how tagging will work.

We should include a script like the generate-stackbrew-library.sh one that many official Dockerfile
repos include to generate the file that is referenced by the [docker-library/official-images|https://github.com/docker-library/official-images/]
repo to actually build and tag all the right permutations.

And regarding this repo living my personal account, I consider that just a temporary arrangement
until we can get these included in docker-library. You're welcome to clone the repo if you
want to experiment with kicking off builds.

Finally, could you expound a little more about your opinion about the relationship between
a Dockerfile included in apache/flink and these official images? I'm not sure if I see the
benefit of trying to keep it around if we have official, publicly available, well-documented
reference Dockerfiles and images available. The one argument I see is building a Docker image
from your work tree if you're a developer, but in that case I think it's a lot less important
to maintain it very actively. It could even just be a Dockerfile that bases itself on the
official image and then replaces the Flink release within with your work tree!

> Publish the flink docker container to the docker registry
> ---------------------------------------------------------
>                 Key: FLINK-3026
>                 URL: https://issues.apache.org/jira/browse/FLINK-3026
>             Project: Flink
>          Issue Type: Task
>          Components: Build System, Docker
>            Reporter: Omer Katz
>            Assignee: Patrick Lucas
>              Labels: Deployment, Docker
> There's a dockerfile that can be used to build a docker container already in the repository.
It'd be awesome to just be able to pull it instead of building it ourselves.
> The dockerfile can be found at https://github.com/apache/flink/tree/master/flink-contrib/docker-flink
> It also doesn't point to the latest version of Flink which I fixed in https://github.com/apache/flink/pull/1366

This message was sent by Atlassian JIRA

View raw message