flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-4460) Side Outputs in Flink
Date Fri, 10 Mar 2017 14:18:05 GMT

    [ https://issues.apache.org/jira/browse/FLINK-4460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15905139#comment-15905139
] 

ASF GitHub Bot commented on FLINK-4460:
---------------------------------------

Github user kl0u commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3484#discussion_r105401808
  
    --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/OperatorChain.java
---
    @@ -441,26 +491,55 @@ public void close() {
     	private static final class CopyingChainingOutput<T> extends ChainingOutput<T>
{
     		
     		private final TypeSerializer<T> serializer;
    -		
    +
     		public CopyingChainingOutput(
     				OneInputStreamOperator<T, ?> operator,
     				TypeSerializer<T> serializer,
    +				OutputTag<T> outputTag,
     				StreamStatusProvider streamStatusProvider) {
    -			super(operator, streamStatusProvider);
    +			super(operator, streamStatusProvider, outputTag);
     			this.serializer = serializer;
     		}
     
    --- End diff --
    
    Again the two `collect()` have duplicate code (after the casting).


> Side Outputs in Flink
> ---------------------
>
>                 Key: FLINK-4460
>                 URL: https://issues.apache.org/jira/browse/FLINK-4460
>             Project: Flink
>          Issue Type: New Feature
>          Components: Core, DataStream API
>    Affects Versions: 1.2.0, 1.1.3
>            Reporter: Chen Qin
>            Assignee: Chen Qin
>              Labels: latearrivingevents, sideoutput
>
> https://docs.google.com/document/d/1vg1gpR8JL4dM07Yu4NyerQhhVvBlde5qdqnuJv4LcV4/edit?usp=sharing



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message