flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-5190) ZooKeeperLeaderRetrievalService should not close the zk client when stop
Date Fri, 10 Mar 2017 10:32:04 GMT

    [ https://issues.apache.org/jira/browse/FLINK-5190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15904864#comment-15904864
] 

ASF GitHub Bot commented on FLINK-5190:
---------------------------------------

Github user tillrohrmann commented on the issue:

    https://github.com/apache/flink/pull/2905
  
    I fear that we cannot merge the PR as it is, because it would leave the `CuratorFramework`
client open for some of the components used in the master. For example, the `WebMonitor` uses
the same code path to open a leader retrieval service in case of HA mode.
    
    In order to solve this problem, I think we have to change the master to also use the `HighAvailabilityServices`.
Then we have a single point of responsibility to close the `CuratorFramework` client.


> ZooKeeperLeaderRetrievalService should not close the zk client when stop
> ------------------------------------------------------------------------
>
>                 Key: FLINK-5190
>                 URL: https://issues.apache.org/jira/browse/FLINK-5190
>             Project: Flink
>          Issue Type: Bug
>          Components: Core
>            Reporter: shuai.xu
>            Assignee: shuai.xu
>              Labels: flip-6
>
> The zk client is created outside of ZooKeeperLeaderRetrievalService and psssed to it,
when ZooKeeperLeaderRetrievalService stop, it should not stop the zk client as other may be
using it outside.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message