flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-5758) Port-range for the web interface via YARN
Date Fri, 03 Mar 2017 10:11:46 GMT

    [ https://issues.apache.org/jira/browse/FLINK-5758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15894055#comment-15894055
] 

ASF GitHub Bot commented on FLINK-5758:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3391#discussion_r103202714
  
    --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/WebMonitorConfig.java
---
    @@ -65,8 +68,14 @@ public String getWebFrontendAddress() {
     		return config.getValue(ConfigConstants.DEFAULT_JOB_MANAGER_WEB_FRONTEND_ADDRESS);
     	}
     
    -	public int getWebFrontendPort() {
    -		return config.getInteger(JOB_MANAGER_WEB_PORT_KEY, DEFAULT_JOB_MANAGER_WEB_FRONTEND_PORT);
    +	public Iterator<Integer> getWebFrontendPortRange() throws IllegalArgumentException
{
    +		String serverPortRange = config.getString(JOB_MANAGER_WEB_PORT_KEY, DEFAULT_JOB_MANAGER_WEB_FRONTEND_PORT);
    +
    +		try {
    +			return NetUtils.getPortRangeFromString(serverPortRange);
    +		} catch (Exception e) {
    +			throw new IllegalArgumentException("Invalid port range definition: " + serverPortRange);
    --- End diff --
    
    Maybe we could add "Invalid port range definition for the job manager's web monitor".


> Port-range for the web interface via YARN
> -----------------------------------------
>
>                 Key: FLINK-5758
>                 URL: https://issues.apache.org/jira/browse/FLINK-5758
>             Project: Flink
>          Issue Type: Sub-task
>          Components: YARN
>    Affects Versions: 1.2.0, 1.1.4, 1.3.0
>            Reporter: Kanstantsin Kamkou
>            Assignee: Yelei Feng
>              Labels: network
>
> In case of YARN, the {{ConfigConstants.JOB_MANAGER_WEB_PORT_KEY}}   [is changed to 0|https://github.com/apache/flink/blob/release-1.2.0/flink-yarn/src/main/java/org/apache/flink/yarn/YarnApplicationMasterRunner.java#L526].
Please allow port ranges in this case. DevOps need that.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message