flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-5758) Port-range for the web interface via YARN
Date Fri, 03 Mar 2017 10:11:46 GMT

    [ https://issues.apache.org/jira/browse/FLINK-5758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15894065#comment-15894065
] 

ASF GitHub Bot commented on FLINK-5758:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3391#discussion_r103205236
  
    --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/minicluster/FlinkMiniCluster.scala
---
    @@ -379,8 +379,7 @@ abstract class FlinkMiniCluster(
           jobManagerAkkaURL: String)
         : Option[WebMonitor] = {
         if(
    -      config.getBoolean(ConfigConstants.LOCAL_START_WEBSERVER, false) &&
    -        config.getInteger(ConfigConstants.JOB_MANAGER_WEB_PORT_KEY, 0) >= 0) {
    +      config.getBoolean(ConfigConstants.LOCAL_START_WEBSERVER, false)) {
    --- End diff --
    
    Why did you remove the other condition? What if the port has been set to `-1`, then the
documentation says that no web server will be started.


> Port-range for the web interface via YARN
> -----------------------------------------
>
>                 Key: FLINK-5758
>                 URL: https://issues.apache.org/jira/browse/FLINK-5758
>             Project: Flink
>          Issue Type: Sub-task
>          Components: YARN
>    Affects Versions: 1.2.0, 1.1.4, 1.3.0
>            Reporter: Kanstantsin Kamkou
>            Assignee: Yelei Feng
>              Labels: network
>
> In case of YARN, the {{ConfigConstants.JOB_MANAGER_WEB_PORT_KEY}}   [is changed to 0|https://github.com/apache/flink/blob/release-1.2.0/flink-yarn/src/main/java/org/apache/flink/yarn/YarnApplicationMasterRunner.java#L526].
Please allow port ranges in this case. DevOps need that.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message