flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-5808) Missing verification for setParallelism and setMaxParallelism
Date Fri, 10 Mar 2017 13:42:04 GMT

    [ https://issues.apache.org/jira/browse/FLINK-5808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15905074#comment-15905074
] 

ASF GitHub Bot commented on FLINK-5808:
---------------------------------------

GitHub user aljoscha opened a pull request:

    https://github.com/apache/flink/pull/3509

    [FLINK-5808] Fix Missing verification for setParallelism and setMaxParallelism

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aljoscha/flink jira-5808-max-parallelism-verification

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3509.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3509
    
----
commit 59b049bbad2c889dcb29ffbd900a458580c20728
Author: Aljoscha Krettek <aljoscha.krettek@gmail.com>
Date:   2017-03-10T12:30:21Z

    [FLINK-5808] Move default parallelism to StreamingJobGraphGenerator
    
    Before, it was set on the ExecutionConfig for some stream execution
    environments and later for others. Now, we don't set the default
    parallelism on the ExecutionConfig but instead set it at the latest
    possible point, in the StreamingJobGraphGenerator.
    
    This also adds tests that verify that we don't set the default
    parallelism on the ExecutionConfig.

commit 5527eae6f29ed80baedd1f5feadf3a4e17ac7865
Author: Aljoscha Krettek <aljoscha.krettek@gmail.com>
Date:   2017-03-10T13:37:26Z

    [FLINK-5808] Move max keygroup constants to ExecutionConfig
    
    We need to have them there if we want to properly test the arguments of
    setMaxParallelism() in the ExecutionConfig itself.

commit 096dcca374a052d90bfe09a5a147435f2614aa05
Author: Aljoscha Krettek <aljoscha.krettek@gmail.com>
Date:   2017-03-10T13:35:37Z

    [FLINK-5808] Add proper checks in setParallelism()/setMaxParallelism()
    
    Before, there where some checks in
    StreamExecutionEnvironment.set(Max)Parallelism() but a user would
    circumvent these if using the ExecutionConfig directly. Now, all checks
    are moved to the ExecutionConfig.

----


> Missing verification for setParallelism and setMaxParallelism
> -------------------------------------------------------------
>
>                 Key: FLINK-5808
>                 URL: https://issues.apache.org/jira/browse/FLINK-5808
>             Project: Flink
>          Issue Type: Bug
>          Components: DataStream API
>    Affects Versions: 1.2.0
>            Reporter: Aljoscha Krettek
>            Priority: Blocker
>             Fix For: 1.3.0, 1.2.1
>
>
> When {{setParallelism()}} is called we don't verify that it is <= than max parallelism.
Likewise, when {{setMaxParallelism()}} is called we don't check that the new value doesn't
clash with a previously set parallelism.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message