flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-5978) JM WebFrontend address ConfigOption is defined in ConfigConstants
Date Thu, 16 Mar 2017 04:56:42 GMT

    [ https://issues.apache.org/jira/browse/FLINK-5978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15927494#comment-15927494

ASF GitHub Bot commented on FLINK-5978:

GitHub user zjureel opened a pull request:


    [FLINK-5978] Fix JM WebFrontend address ConfigOption is defined in Co…

    Thanks for contributing to Apache Flink. Before you open your pull request, please take
the following check list into consideration.
    If your changes take all of the items into account, feel free to open your pull request.
For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful description of your
    - [ ] General
      - The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the JIRA id)
    - [ ] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    - [ ] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zjureel/flink master

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3552
commit 6a611f5b1649af8f40c97014267a681cec1c0df9
Author: mengji.fy <mengji.fy@taobao.com>
Date:   2017-03-16T04:53:03Z

    [FLINK-5978] Fix JM WebFrontend address ConfigOption is defined in ConfigConstants


> JM WebFrontend address ConfigOption is defined in ConfigConstants
> -----------------------------------------------------------------
>                 Key: FLINK-5978
>                 URL: https://issues.apache.org/jira/browse/FLINK-5978
>             Project: Flink
>          Issue Type: Bug
>          Components: JobManager
>    Affects Versions: 1.3.0
>            Reporter: Chesnay Schepler
>            Priority: Blocker
>             Fix For: 1.3.0
> The DEFAULT_JOB_MANAGER_WEB_FRONTEND_ADDRESS ConfigOption is defined in ConfigConstants
instead of JobManagerOptions.
> Additionally, the name should not contain DEFAULT_ since it doesn't even define a default

This message was sent by Atlassian JIRA

View raw message