flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #3356: [FLINK-5253] Remove special treatment of "dynamic ...
Date Wed, 05 Jul 2017 15:13:47 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3356#discussion_r125670830
  
    --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java
---
    @@ -711,8 +701,18 @@ public FileVisitResult preVisitDirectory(java.nio.file.Path dir,
BasicFileAttrib
     		LocalResource flinkConf = Records.newRecord(LocalResource.class);
     		Path remotePathJar =
     			Utils.setupLocalResource(fs, appId.toString(), flinkJarPath, appMasterJar, fs.getHomeDirectory());
    -		Path remotePathConf =
    -			Utils.setupLocalResource(fs, appId.toString(), flinkConfigurationPath, flinkConf,
fs.getHomeDirectory());
    +
    +		final org.apache.flink.configuration.Configuration dynamicProperties = GlobalConfiguration.getDynamicProperties();
    --- End diff --
    
    Can't we pass this configuration into the `ClusterDescriptor` differently? What about
reading it when creating the descriptor and then passing it as a constructor parameter? Even
better, we could read the global configuration, then parse the dynamic properties, adding
them to the read config and then creating the descriptor.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message