flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From greghogan <...@git.apache.org>
Subject [GitHub] flink pull request #4169: [FLINK-6357] [java] ParameterTool get unrequested ...
Date Mon, 10 Jul 2017 10:22:57 GMT
Github user greghogan commented on a diff in the pull request:

    --- Diff: flink-java/src/main/java/org/apache/flink/api/java/utils/ParameterTool.java
    @@ -548,6 +565,7 @@ protected Object clone() throws CloneNotSupportedException {
     	public ParameterTool mergeWith(ParameterTool other) {
     		ParameterTool ret = new ParameterTool(this.data);
    +		ret.unrequestedParameters.addAll(other.data.keySet());
    --- End diff --
    This original behaviors was incorrect and I've changed this to `ret.unrequestedParameters.addAll(other.unrequestedParameters);`.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message