flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From greghogan <...@git.apache.org>
Subject [GitHub] flink pull request #4169: [FLINK-6357] [java] ParameterTool get unrequested ...
Date Mon, 10 Jul 2017 10:22:57 GMT
Github user greghogan commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4169#discussion_r126318967
  
    --- Diff: flink-java/src/test/java/org/apache/flink/api/java/utils/ParameterToolTest.java
---
    @@ -34,8 +36,7 @@
     
     	@Test(expected = RuntimeException.class)
     	public void testIllegalArgs() {
    -		ParameterTool parameter = ParameterTool.fromArgs(new String[]{"berlin"});
    -		Assert.assertEquals(0, parameter.getNumberOfParameters());
    --- End diff --
    
    The tests are throwing exceptions when creating the `ParameterTool` so the assertions
are never tested.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message