flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zentol <...@git.apache.org>
Subject [GitHub] flink pull request #4110: [FLINK-6900] [metrics] Limit size of metric name c...
Date Wed, 12 Jul 2017 10:10:44 GMT
Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4110#discussion_r126915402
  
    --- Diff: flink-metrics/flink-metrics-statsd/src/test/java/org/apache/flink/metrics/statsd/StatsDReporterTest.java
---
    @@ -60,6 +60,20 @@
     public class StatsDReporterTest extends TestLogger {
     
     	@Test
    +	public void testNameTruncating() {
    +		StatsDReporter reporter = new StatsDReporter();
    +
    +		MetricConfig config = new MetricConfig();
    +		config.setProperty(StatsDReporter.ARG_HOST, "localhost");
    +		config.setProperty(StatsDReporter.ARG_PORT, "12345");
    +		config.setProperty(StatsDReporter.ARG_MAX_COMPONENT_LENGTH, "10");
    +		
    +		reporter.open(config);
    +		
    +		assertEquals("0123456789", reporter.filterCharacters("0123456789DEADBEEF"));
    --- End diff --
    
    What about the tests?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message