flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #3829: [FLINK-6442] [table] Extend TableAPI Support Sink ...
Date Fri, 14 Jul 2017 13:55:33 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3829#discussion_r127446535
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/BatchTableEnvironment.scala
---
    @@ -319,7 +337,7 @@ abstract class BatchTableEnvironment(
         * @tparam A The type of the resulting [[DataSet]].
         * @return The [[DataSet]] that corresponds to the translated [[Table]].
         */
    -  protected def translate[A](table: Table)(implicit tpe: TypeInformation[A]): DataSet[A]
= {
    +  def translate[A](table: Table)(implicit tpe: TypeInformation[A]): DataSet[A] = {
    --- End diff --
    
    why did you make this method public? 
    I think it should be hidden from users.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message