flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #3829: [FLINK-6442] [table] Extend TableAPI Support Sink ...
Date Fri, 14 Jul 2017 13:55:37 GMT
Github user fhueske commented on a diff in the pull request:

    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala
    @@ -488,19 +499,50 @@ abstract class TableEnvironment(val config: TableConfig) {
         *   tEnv.sql(s"SELECT * FROM $table")
         * }}}
    -    * @param query The SQL query to evaluate.
    -    * @return The result of the query as Table.
    +    * @param sql The SQL string to evaluate.
    +    * @return The result of the query as Table or null of the DML insert operation.
    -  def sql(query: String): Table = {
    +  def sql(sql: String): Table = {
    --- End diff --
    I'm not sure if we should add this functionality to the `sql()` method. The `sql()` method
returns a `Table` which I would not expect if I define an `INSERT INTO` statement. Returning
`null` is not a good idea in my opinion.
    I would rather add a new method maybe called `sqlInsert()`. The method would check the
query type and could also give a meaningful error message with a hint of which method should
be used instead.
    What do you think @lincoln-lil?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message