flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zentol <...@git.apache.org>
Subject [GitHub] flink pull request #4340: [FLINK-7185] Activate checkstyle flink-java/io
Date Fri, 14 Jul 2017 17:23:34 GMT
Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4340#discussion_r127504763
  
    --- Diff: flink-java/src/main/java/org/apache/flink/api/java/io/PrintingOutputFormat.java
---
    @@ -18,12 +18,16 @@
     
     package org.apache.flink.api.java.io;
     
    -import java.io.PrintStream;
    -
     import org.apache.flink.annotation.PublicEvolving;
     import org.apache.flink.api.common.io.RichOutputFormat;
     import org.apache.flink.configuration.Configuration;
     
    +import java.io.PrintStream;
    +
    +/**
    + * Output format that prints results into underlying {@link PrintStream}.
    --- End diff --
    
    I would reword this to mention stdout/stderr; the usage of `PrintStream` is an (unimportant)
implementation detail.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message