flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zentol <...@git.apache.org>
Subject [GitHub] flink pull request #4340: [FLINK-7185] Activate checkstyle flink-java/io
Date Fri, 14 Jul 2017 17:23:34 GMT
Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4340#discussion_r127506187
  
    --- Diff: flink-java/src/test/java/org/apache/flink/api/java/io/CsvInputFormatTest.java
---
    @@ -224,34 +230,31 @@ private void ignoreInvalidLines(int bufferSize) {
     			fail("Test failed due to a " + ex.getClass().getName() + ": " + ex.getMessage());
     		}
     	}
    -	
    +
     	@Test
     	public void ignoreSingleCharPrefixComments() {
     		try {
     			final String fileContent = "#description of the data\n" +
    -									   "#successive commented line\n" +
    -									   "this is|1|2.0|\n" +
    -									   "a test|3|4.0|\n" +
    -									   "#next|5|6.0|\n";
    -			
    +										"#successive commented line\n" + "this is|1|2.0|\n" + "a test|3|4.0|\n" + "#next|5|6.0|\n";
    --- End diff --
    
    lets move this line more to the left and keep them in separate lines


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message