flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dawidwys <...@git.apache.org>
Subject [GitHub] flink pull request #4340: [FLINK-7185] Activate checkstyle flink-java/io
Date Sat, 15 Jul 2017 09:08:19 GMT
Github user dawidwys commented on a diff in the pull request:

    --- Diff: flink-java/src/main/java/org/apache/flink/api/java/io/CsvReader.java ---
    @@ -23,9 +23,32 @@
     import org.apache.flink.api.java.ExecutionEnvironment;
     import org.apache.flink.api.java.Utils;
     import org.apache.flink.api.java.operators.DataSource;
    -//CHECKSTYLE.OFF: AvoidStarImport - Needed for TupleGenerator
    -import org.apache.flink.api.java.tuple.*;
    -//CHECKSTYLE.ON: AvoidStarImport
    +import org.apache.flink.api.java.tuple.Tuple;
    +import org.apache.flink.api.java.tuple.Tuple1;
    +import org.apache.flink.api.java.tuple.Tuple10;
    +import org.apache.flink.api.java.tuple.Tuple11;
    +import org.apache.flink.api.java.tuple.Tuple12;
    +import org.apache.flink.api.java.tuple.Tuple13;
    +import org.apache.flink.api.java.tuple.Tuple14;
    +import org.apache.flink.api.java.tuple.Tuple15;
    +import org.apache.flink.api.java.tuple.Tuple16;
    +import org.apache.flink.api.java.tuple.Tuple17;
    +import org.apache.flink.api.java.tuple.Tuple18;
    +import org.apache.flink.api.java.tuple.Tuple19;
    --- End diff --
    Oh, ok. I didn't notice, it was because of code generation previously. How do we want
to proceed with it then? Do we want to add suppression for it? Just adding the `//CHECKSTYLE:
OFF` won't work as it violates the `ImportOrder` rule.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message