flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink issue #4263: [FLINK-6075] - Support Limit/Top(Sort) for Stream SQL
Date Tue, 18 Jul 2017 09:30:22 GMT
Github user fhueske commented on the issue:

    https://github.com/apache/flink/pull/4263
  
    Thanks @rtudoran. 
    
    Regarding PR it is up to you whether you'd like to update the current or open a new one.
I think the new version will have less changes (LOCs and files) because we only need to add
a few counters and conditions to `ProcTimeSortProcessFunction` and `RowTimeSortProcessFunction`.

    
    Regarding the JIRA, I would change the title and description of FLINK-6075 describe the
`ORDER BY *time ASC` case (i.e., what is already implemented and merged) and open new JIRAs
for 
    - `ORDER BY *time ASC OFFSET FETCH`
    - `ORDER BY *time DESC OFFSET FETCH`
    - `ORDER BY * OFFSET FETCH`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message