flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From NicoK <...@git.apache.org>
Subject [GitHub] flink pull request #4342: [FLINK-7181] Activate checkstyle flink-java/operat...
Date Tue, 18 Jul 2017 14:40:39 GMT
Github user NicoK commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4342#discussion_r127988555
  
    --- Diff: flink-java/src/main/java/org/apache/flink/api/java/operators/CoGroupRawOperator.java
---
    @@ -95,9 +96,8 @@ public CoGroupRawOperator(DataSet<I1> input1, DataSet<I2>
input2,
     			int[] logicalKeyPositions1 = keys1.computeLogicalKeyPositions();
     			int[] logicalKeyPositions2 = keys2.computeLogicalKeyPositions();
     
    -			CoGroupRawOperatorBase<I1, I2, OUT, CoGroupFunction<I1, I2, OUT>> po
    -					= new CoGroupRawOperatorBase<I1, I2, OUT, CoGroupFunction<I1, I2, OUT>>(
    -							function, new BinaryOperatorInformation<I1, I2, OUT>(getInput1Type(), getInput2Type(),

    +			CoGroupRawOperatorBase<I1, I2, OUT, CoGroupFunction<I1, I2, OUT>> po =
new CoGroupRawOperatorBase<I1, I2, OUT, CoGroupFunction<I1, I2, OUT>>(
    --- End diff --
    
    now this line is a bit too long (even if the caret shortcut `<>` was used)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message