flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rtudoran <...@git.apache.org>
Subject [GitHub] flink issue #4263: [FLINK-6075] - Support Limit/Top(Sort) for Stream SQL
Date Wed, 19 Jul 2017 07:55:52 GMT
Github user rtudoran commented on the issue:

    https://github.com/apache/flink/pull/4263
  
    @fhueske ,@wuchong  thanks for the feedback. I will modify all these today - tomorrow
and ping you when they are pushed.
    
    @wuchong - TopN for each group should not be hard to implement. In fact if you look at
the logic of how things are implemented we are in a similar setup as for OVER windows. We
have the input stream and we apply a keyBy and the processfunction (for order by / fetch/offset).
Thus we would only need the Calcite syntax to make sure the partition fields are pushed in
the LogicalSort object. Did you try to see if you have directly a group by if this is pushed
in the sort object?
    Otherwise we can make a rule to combine a Group object with the sort object


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message