flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zentol <...@git.apache.org>
Subject [GitHub] flink pull request #4337: [FLINK-7187] Activate checkstyle flink-java/sca
Date Wed, 19 Jul 2017 15:13:27 GMT
Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4337#discussion_r128276458
  
    --- Diff: flink-java/src/main/java/org/apache/flink/api/java/sca/TaggedValue.java ---
    @@ -46,7 +50,10 @@
     		NULL // null
     	}
     
    -	public static enum Input {
    +	/**
    +	 * Inputs types.
    --- End diff --
    
    This is a bit misleading, I believe these are used a tags to remember which input they
belong to for 2 input operators (like coGroup for example). They may have the same type though
;)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message