flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zentol <...@git.apache.org>
Subject [GitHub] flink issue #4343: [FLINK-7190] Activate checkstyle flink-java/*
Date Wed, 19 Jul 2017 15:30:00 GMT
Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/4343
  
    The switch statements can be modified to be checkstyle compliant with few changes.
    `NestedMethodAnalyzer#naryOperation`:
    ```
    ...
    case INVOKESTATIC:
    case INVOKESPECIAL:
    case INVOKEVIRTUAL:
    case INVOKEINTERFACE:
    	isStatic = insn.getOpCoed() == INVOKESTATIC;
    ...
    ```
    
    `NestedMethodAnalyzer#copyOperation`:
    ```
    ...
    case DUP2_X2:
    	if (isTagged(value) && tagged(value).isInput() && tagged(value).isCallByValue())
{
    		return tagged(value).copy();
    	} else {
    		return super.copyOperation(insn, value);
    	}
    ...
    ```
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message