flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dawidwys <...@git.apache.org>
Subject [GitHub] flink pull request #4335: [FLINK-7192] Activate checkstyle flink-java/test/o...
Date Tue, 25 Jul 2017 08:30:48 GMT
Github user dawidwys commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4335#discussion_r129242316
  
    --- Diff: flink-java/src/test/java/org/apache/flink/api/java/operator/SortPartitionTest.java
---
    @@ -251,32 +254,42 @@ public CustomType getKey(Tuple4<Integer, Long, CustomType, Long[]>
value) throws
     			.sortPartition("f1", Order.ASCENDING);
     	}
     
    +	/**
    +	 * Custom data type, for testing purposes.
    +	 */
     	public static class CustomType implements Serializable {
    -		
    +
    +		/**
    +		 * Custom nested data type, for testing purposes.
    +		 */
     		public static class Nest {
     			public int myInt;
     		}
    +
     		private static final long serialVersionUID = 1L;
    -		
    +
     		public int myInt;
     		public long myLong;
     		public String myString;
     		public Nest nested;
    -		
    +
     		public CustomType() {}
     
     		public CustomType(int i, long l, String s) {
     			myInt = i;
     			myLong = l;
     			myString = s;
     		}
    -		
    +
     		@Override
     		public String toString() {
    -			return myInt+","+myLong+","+myString;
    +			return myInt + "," + myLong + "," + myString;
     		}
     	}
     
    +	/**
    +	 * Another custom data type, for testing purposes.
    --- End diff --
    
    I removed this class entirely as it was not used.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message