flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dawidwys <...@git.apache.org>
Subject [GitHub] flink pull request #4331: [FLINK-7169][CEP] Support AFTER MATCH SKIP functio...
Date Tue, 25 Jul 2017 13:30:22 GMT
Github user dawidwys commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4331#discussion_r129296465
  
    --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/CEP.java ---
    @@ -36,6 +40,14 @@
     	 * @return Resulting pattern stream
     	 */
     	public static <T> PatternStream<T> pattern(DataStream<T> input, Pattern<T,
?> pattern) {
    -		return new PatternStream<>(input, pattern);
    +		return new PatternStream<>(input, pattern, skipStrategy);
    +	}
    +
    +	/**
    +	 * Set the pattern's skip strategy after match.
    +	 * @param afterMatchSkipStrategy the skip strategy to use.
    +	 */
    +	public static void setAfterMatchSkipStrategy(AfterMatchSkipStrategy afterMatchSkipStrategy)
{
    --- End diff --
    
    As @dianfu said in the corresponding JIRA, the `AfterMatchSkipStrategy` should be part
of the `Pattern` not `PatternStream`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message