flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dawidwys <...@git.apache.org>
Subject [GitHub] flink pull request #4331: [FLINK-7169][CEP] Support AFTER MATCH SKIP functio...
Date Tue, 25 Jul 2017 13:30:22 GMT
Github user dawidwys commented on a diff in the pull request:

    --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java ---
    @@ -551,18 +579,47 @@ private boolean isSelfIgnore(final StateTransition<T> edge)
    +					switch (skipStrategy.getStrategy()) {
    +						case SKIP_PAST_LAST_ROW:
    +							if (nextState.isFinal()) {
    +								resultingComputationStates.add(createStartComputationState(computationState,
    +							}
    +							break;
    +						case SKIP_TO_FIRST:
    +							if (nextState.getName().equals(skipStrategy.getRpv()) &&
    +								!nextState.getName().equals(currentState.getName())) {
    +								ComputationState<T> startComputationState = createStartComputationState(computationState,
    --- End diff --
    The `outgoingEdges` parameter in this case will not work. Previously the assumption was
that we created the new `start` state always in the starting state. So we could calculate
the version for new run based on outgoing edges from the start state. 
    In this case the outgoingEdges do not correspond to the starting state.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message