flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #4271: [FLINK-7113] Make ClusterDescriptor independent of...
Date Wed, 26 Jul 2017 10:06:38 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4271#discussion_r129531644
  
    --- Diff: flink-yarn-tests/src/test/java/org/apache/flink/yarn/YarnTestBase.java ---
    @@ -631,12 +634,15 @@ protected static void sendOutput() {
     	protected static class Runner extends Thread {
     		private final String[] args;
     		private final int expectedReturnValue;
    +		private final org.apache.flink.configuration.Configuration configuration;
    +
     		private RunTypes type;
     		private FlinkYarnSessionCli yCli;
     		private Throwable runnerError;
     
    -		public Runner(String[] args, RunTypes type, int expectedReturnValue) {
    +		public Runner(String[] args, org.apache.flink.configuration.Configuration configuration,
RunTypes type, int expectedReturnValue) {
    --- End diff --
    
    True. Then I think it is not needed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message