flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lincoln-lil <...@git.apache.org>
Subject [GitHub] flink issue #3829: [FLINK-6442] [table] Extend TableAPI Support Sink Table R...
Date Thu, 27 Jul 2017 02:34:53 GMT
Github user lincoln-lil commented on the issue:

    https://github.com/apache/flink/pull/3829
  
    Hi @fhueske, agree with you, this API change should be discussed on dev mailing list.
    Including:
    add two new method to`table.scala`
    - `def insertInto[T](tableSink: String): Unit`
    - `def insertInto[T](tableSink: String, conf: QueryConfig): Unit ` 
    
    deprecate the current `sql` method and add two new methods to `TableEnvironment`
    - `@deprecated def sql(sql: String): Table`
    - `def sqlQuery(sql: String): Table`
    - `def sqlUpdate(sql: String, config: QueryConfig): Unit`  After thought it over, I think
the method here is different from Jdbc's executeUpdate which returns a `int` value, because
`sqlUpdate` will not trigger an execution immediately,  so keep the return value as `Unit`
sounds reasonable and doesn't breakdown the consistency of Scala and Java APIs .
    
    It's a good idea to call `SqlParser.parseQuery()` distinguishing `SELECT` queries from
`INSERT` or `UPDATE` queries.
    I'll start a DISCUSS thread ASAP.
    
    Thanks, Lincoln



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message