flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6357) ParameterTool get unrequested parameters
Date Thu, 06 Jul 2017 14:25:03 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16076584#comment-16076584

ASF GitHub Bot commented on FLINK-6357:

Github user NicoK commented on a diff in the pull request:

    --- Diff: flink-java/src/main/java/org/apache/flink/api/java/utils/ParameterTool.java
    @@ -548,6 +565,7 @@ protected Object clone() throws CloneNotSupportedException {
     	public ParameterTool mergeWith(ParameterTool other) {
     		ParameterTool ret = new ParameterTool(this.data);
    +		ret.unrequestedParameters.addAll(other.data.keySet());
    --- End diff --
    The docs should probably state how unrequested parameters are handles here, i.e. the returned
`ParameterTool` will have have its unrequested parameters reset. An alternative idiom may
be to actually keep the old `unrequestedParameters` in `ret` and merge them with `other.unrequestedParameters`.
What do you thinks makes most sense?

> ParameterTool get unrequested parameters
> ----------------------------------------
>                 Key: FLINK-6357
>                 URL: https://issues.apache.org/jira/browse/FLINK-6357
>             Project: Flink
>          Issue Type: Improvement
>          Components: Java API
>    Affects Versions: 1.3.0
>            Reporter: Greg Hogan
>            Assignee: Greg Hogan
>            Priority: Minor
> The Gelly examples use {{ParameterTool}} to parse required and optional parameters. In
the latter case we should detect if a user mistypes a parameter name. I would like to add
a {{Set<String> getUnrequestedParameters()}} method returning parameter names not requested
by {{has}} or any of the {{get}} methods.

This message was sent by Atlassian JIRA

View raw message