flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6442) Extend TableAPI Support Sink Table Registration and ‘insert into’ Clause in SQL
Date Thu, 27 Jul 2017 02:35:02 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16102617#comment-16102617
] 

ASF GitHub Bot commented on FLINK-6442:
---------------------------------------

Github user lincoln-lil commented on the issue:

    https://github.com/apache/flink/pull/3829
  
    Hi @fhueske, agree with you, this API change should be discussed on dev mailing list.
    Including:
    add two new method to`table.scala`
    - `def insertInto[T](tableSink: String): Unit`
    - `def insertInto[T](tableSink: String, conf: QueryConfig): Unit ` 
    
    deprecate the current `sql` method and add two new methods to `TableEnvironment`
    - `@deprecated def sql(sql: String): Table`
    - `def sqlQuery(sql: String): Table`
    - `def sqlUpdate(sql: String, config: QueryConfig): Unit`  After thought it over, I think
the method here is different from Jdbc's executeUpdate which returns a `int` value, because
`sqlUpdate` will not trigger an execution immediately,  so keep the return value as `Unit`
sounds reasonable and doesn't breakdown the consistency of Scala and Java APIs .
    
    It's a good idea to call `SqlParser.parseQuery()` distinguishing `SELECT` queries from
`INSERT` or `UPDATE` queries.
    I'll start a DISCUSS thread ASAP.
    
    Thanks, Lincoln



> Extend TableAPI Support Sink Table Registration and ‘insert into’ Clause in SQL
> -------------------------------------------------------------------------------
>
>                 Key: FLINK-6442
>                 URL: https://issues.apache.org/jira/browse/FLINK-6442
>             Project: Flink
>          Issue Type: New Feature
>          Components: Table API & SQL
>            Reporter: lincoln.lee
>            Assignee: lincoln.lee
>            Priority: Minor
>
> Currently in TableAPI  there’s only registration method for source table,  when we
use SQL writing a streaming job, we should add additional part for the sink, like TableAPI
does:
> {code}
> val sqlQuery = "SELECT * FROM MyTable WHERE _1 = 3"
> val t = StreamTestData.getSmall3TupleDataStream(env)
> tEnv.registerDataStream("MyTable", t)
> // one way: invoke tableAPI’s writeToSink method directly
> val result = tEnv.sql(sqlQuery)
> result.writeToSink(new YourStreamSink)
> // another way: convert to datastream first and then invoke addSink 
> val result = tEnv.sql(sqlQuery).toDataStream[Row]
> result.addSink(new StreamITCase.StringSink)
> {code}
> From the api we can see the sink table always be a derived table because its 'schema'
is inferred from the result type of upstream query.
> Compare to traditional RDBMS which support DML syntax, a query with a target output could
be written like this:
> {code}
> insert into table target_table_name
> [(column_name [ ,...n ])]
> query
> {code}
> The equivalent form of the example above is as follows:
> {code}
>     tEnv.registerTableSink("targetTable", new YourSink)
>     val sql = "INSERT INTO targetTable SELECT a, b, c FROM sourceTable"
>     val result = tEnv.sql(sql)
> {code}
> It is supported by Calcite’s grammar: 
> {code}
>  insert:( INSERT | UPSERT ) INTO tablePrimary
>  [ '(' column [, column ]* ')' ]
>  query
> {code}
> I'd like to extend Flink TableAPI to support such feature.  see design doc: https://goo.gl/n3phK5



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message